Skip to content

new tests for enumpure_solve in pure strategies and behaviors#609

Merged
tturocy merged 3 commits intomasterfrom
tests_for_enumpure_solve
Jan 9, 2026
Merged

new tests for enumpure_solve in pure strategies and behaviors#609
tturocy merged 3 commits intomasterfrom
tests_for_enumpure_solve

Conversation

@rahulsavani
Copy link
Copy Markdown
Member

No description provided.

@rahulsavani rahulsavani requested a review from tturocy November 13, 2025 09:04
@tturocy
Copy link
Copy Markdown
Member

tturocy commented Nov 17, 2025

In the light of the discussion in #617, does it make sense to add these now or to develop them as part of the changes indicated there?

@rahulsavani
Copy link
Copy Markdown
Member Author

We should add them as part of the changes for #617. Also, I note that none of the test instances for enumpure_solve "agent" currently have agent-form equilibria that are not also Nash equilibria -- such tests should be added.

@tturocy tturocy marked this pull request as draft December 18, 2025 15:40
@rahulsavani
Copy link
Copy Markdown
Member Author

We should add them as part of the changes for #617. Also, I note that none of the test instances for enumpure_solve "agent" currently have agent-form equilibria that are not also Nash equilibria -- such tests should be added.

This is now done in this branch with a game now called myerson_fig_4_2.efg, which is tested in test_nash.py::test_enumpure_agent to ensure that we find both the true Nash and the agent Nash.

Note that myerson_fig_4_2.efg is also used in test_behavior.py::test_agent_max_regret_versus_non_agent which confirms that while agent_max_regret is 0, max_regret >0 for the non-true-Nash agent equilibrium.

@rahulsavani rahulsavani marked this pull request as ready for review January 8, 2026 16:00
@tturocy tturocy merged commit 6dbc0d0 into master Jan 9, 2026
26 checks passed
@tturocy tturocy deleted the tests_for_enumpure_solve branch January 9, 2026 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants